Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] MIG purchase_quick #2171

Open
wants to merge 49 commits into
base: 16.0
Choose a base branch
from
Open

Conversation

legalsylvain
Copy link
Contributor

@legalsylvain legalsylvain commented Feb 9, 2024

  • Port purchase_quick in V16.

supersed : #1872

Copy link
Member

@carmenbianca carmenbianca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, two small comments. Thanks @legalsylvain !

Comment on lines 52 to 60
return {
"product_uom": product.quick_uom_id.id,
"product_qty": product.qty_to_process,
}
return OrderedDict(
{
"product_id": None,
"product_uom": product.quick_uom_id.id,
"product_qty": product.qty_to_process,
}
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Insertion order is guaranteed for regular Python dicts since Python 3.7. OrderedDict is not needed here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@@ -1 +1,2 @@
odoo_test_helper
git+https://github.com/OCA/product-attribute@refs/pull/1512/head#subdirectory=setup/base_product_mass_addition
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer needed; OCA/product-attribute#1512 is merged

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@legalsylvain legalsylvain force-pushed the 16.0-mig-purchase_quick branch 2 times, most recently from 2473f33 to 1dbf073 Compare September 24, 2024 15:05
Pierrick Brun and others added 22 commits October 13, 2024 16:12
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_quick
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_quick/
Currently translated at 54.5% (6 of 11 strings)

Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_quick
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_quick/fr/
Currently translated at 100.0% (11 of 11 strings)

Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_quick
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_quick/fr/
…issions instead of product.product permissions
sebastienbeau and others added 26 commits October 13, 2024 16:12
Currently translated at 45.4% (5 of 11 strings)

Translation: purchase-workflow-14.0/purchase-workflow-14.0-purchase_quick
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-14-0/purchase-workflow-14-0-purchase_quick/fr/
Currently translated at 72.7% (8 of 11 strings)

Translation: purchase-workflow-14.0/purchase-workflow-14.0-purchase_quick
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-14-0/purchase-workflow-14-0-purchase_quick/fr/
Currently translated at 100.0% (17 of 17 strings)

Translation: purchase-workflow-14.0/purchase-workflow-14.0-purchase_quick
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-14-0/purchase-workflow-14-0-purchase_quick/it/
Currently translated at 100.0% (13 of 13 strings)

Translation: purchase-workflow-15.0/purchase-workflow-15.0-purchase_quick
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-15-0/purchase-workflow-15-0-purchase_quick/es/
Currently translated at 100.0% (17 of 17 strings)

Translation: purchase-workflow-15.0/purchase-workflow-15.0-purchase_quick
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-15-0/purchase-workflow-15-0-purchase_quick/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: purchase-workflow-15.0/purchase-workflow-15.0-purchase_quick
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-15-0/purchase-workflow-15-0-purchase_quick/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: purchase-workflow-15.0/purchase-workflow-15.0-purchase_quick
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-15-0/purchase-workflow-15-0-purchase_quick/
- Adapt module to V16.
- rename 'name' into 'partner_id' on supplier.info model
- remove test that make modules incompatible with a lot of other module in purchase repo. (purchase_security, etc...)
product_in_quick_edit.write(
{"qty_to_process": 5.0, "quick_uom_id": self.uom_unit.id}
)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you remove this test ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember exactly. (It was 9 monthes ago ;-) !), As far as I remember, there were messy incompatibilities with other module in the same repo, that change access rights.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.